Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the npm publish workflow to use OpenID Connect (OIDC) authentication instead of token-based authentication. The changes modernize the authentication method and simplify several shell commands by using JSON output with jq parsing.
- Switches from NPM_TOKEN secret to OIDC authentication for npm publish
- Refactors shell commands to use JSON output with jq instead of complex grep/sed patterns
- Adds id-token: write permission required for OIDC authentication
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -70,5 +71,4 @@ jobs: | |||
| git push --tags | |||
| npm publish --access public | |||
There was a problem hiding this comment.
The workflow removes NODE_AUTH_TOKEN but doesn't configure npm to use OIDC authentication. You need to add npm config set //registry.npmjs.org/:_authToken=$NPM_TOKEN where NPM_TOKEN is automatically provided by GitHub's OIDC, or configure the registry authentication in a separate step before publishing.
cp-20
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as titled
merge 前に、こちら↓ の手順を npm 管理画面側からやっておく必要があります
https://docs.npmjs.com/trusted-publishers#for-github-actions
ついでに検証時に
grepの-Pが mac 環境で使えなくて落ちていたので、それも json 出力を使って記述を簡略化しました