Skip to content

Sync develop → main (prepare next release)#49

Merged
aptracebloc merged 14 commits into
mainfrom
develop
Jun 4, 2026
Merged

Sync develop → main (prepare next release)#49
aptracebloc merged 14 commits into
mainfrom
develop

Conversation

@aptracebloc
Copy link
Copy Markdown
Contributor

@aptracebloc aptracebloc commented Jun 4, 2026

Brings main current with develop — its first sync since the v0.1.0-alpha cut (#22). No tag is cut here; this just updates main ahead of the next release.

Note: v0.1.0 (stable, "Latest") was already tagged on a develop commit (0ba4cd8), so the headline features below already shipped there. This sync lands them on main along with the post-v0.1.0 polish (#44, #46, #47).

What's new since v0.1.0-alpha

Installer-style terminal UX (epic #31)

New command

Scripting

Fixes

CI / release


Merge via merge commit (per the develop→main convention), not squash.

🤖 Generated with Claude Code


Note

Medium Risk
Adds a destructive dataset rm path that execs into cluster pods and drops MySQL tables; UX and JSON contracts are broad but covered by new tests, with no changes to core auth or submit protocol.

Overview
This sync lands v0.2-style CLI polish and capabilities on main ahead of the next tag — no release is cut in this PR itself.

Terminal UX: A new internal/ui layer drives banners, numbered steps, and status lines across cluster info, dataset push, and ingestion summaries (replacing raw fmt and the old Unicode box panel). The root command shows a home screen instead of a bare usage dump; --plain disables color for CI/logs.

dataset push: Optional interactive mode (survey prompts for missing path, category, table, and category-specific fields, with a review confirm). --output-json puts machine-readable results on stdout and human text on stderr, including early failures; classifyPushOutcome keeps JSON status aligned with exit codes (e.g. partial failures ≠ succeeded). expandHome fixes ~ paths from prompts and quoted args.

dataset rm: New command to drop the ingestion MySQL table and remove final + staging PVC paths via exec into chart pods (documented limitation: backend catalog not removed).

Release/CI: Build and release workflows expand from five to eight targets (linux 386/arm with GOARM=6, windows arm64); install scripts and README reflect stable latest installs and multi-arch support.

Reviewed by Cursor Bugbot for commit 74b2ba5. Bugbot is set up for automated code reviews on this repo. Configure here.

aptracebloc and others added 12 commits June 3, 2026 16:22
* feat(#26): add internal/ui installer-style terminal UX package

Printer renders colored step/✔/⚠/· output matching the tracebloc/client installer (scripts/lib/common.sh). TTY+NO_COLOR auto-detect with a WithColor override (functional-options); fatih/color forced per-instance so it's testable on a buffer. Helpers: Banner, Step, Successf, Warnf, Infof, Errorf, Hintf, PromptHeader.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat(#26): render dataset push pre-flight via internal/ui + add --plain

Adds a persistent --plain root flag and a printerFor(cmd) helper, plus ui.Section/ui.Field. dataset push pre-flight now renders through the ui.Printer (colored Section/Field rows, ⚠ for the RWO warning) instead of ad-hoc fmt.Fprintf; behavior unchanged (the pinned RendersKeyFacts test still passes).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat(#26): render cluster info via internal/ui

cluster info now prints through the ui.Printer (Section/Field + a green ✔ ready line) instead of raw fmt.Fprintf, matching the dataset push pre-flight. Test updated for the *ui.Printer signature (still asserts exit-3 on a bad kubeconfig).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Replaces the box-drawing RenderPanel with RenderSummary(p *ui.Printer, s): an outcome-colored headline (green clean / yellow skips / red failures) + Section/Field counts + a 'what's next' block. Dropping the Unicode box resolves the v0.2 plain-ASCII TODO. submit.Options gains Printer (nil → ui.New(Out)); dataset push threads its --plain-aware printer through. Parser untouched. RenderPanel tests → RenderSummary (basic shape, nil, table-driven outcome).

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…R-a) (#34)

On a TTY (unless --no-input), dataset push now prompts for any missing core inputs (path, category, table, intent, label) before validation; flags already passed win. Introduces a prompter interface (survey-backed in prod, fake in tests) so the prompt-mapping is unit-testable without a pseudo-terminal. Args ExactArgs(1)->MaximumNArgs(1) so a bare command can prompt for the path; explicit path-required error otherwise. MLM skips the label prompt; the table prompt reuses push.ValidateTableName. PR-b adds category-specific prompts + a confirm screen.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Completes the guided dataset push. After the core prompts, asks only what each category needs: image resolution (blank=auto-detect), required keypoint count, tabular schema (blank=infer) + regression label-policy + time-column. Then a Review screen + 'Proceed?' confirm — shown only when something was actually prompted, so full-flag pushes aren't nagged. Declining or Ctrl-C (survey terminal.InterruptErr, translated to errInteractiveCancelled at the prompter boundary) exits cleanly (0). Prompter interface gains Confirm; fake-prompter tests cover keypoint, tabular-regression, and cancel.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Bare 'tracebloc' (no subcommand) now renders a branded home screen — ui.Banner + a 'get started' command list — via root.RunE, instead of cobra's raw usage dump; subcommands and --help are unaffected. cluster info gains a Banner header. PR-a of #29; --output-json follows in PR-b (it needs runDatasetPush to return a result struct + JSON tags on Summary, so it's its own change).

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(#29): --output-json for dataset push (PR-b)

--output-json emits a machine-readable JSON result on stdout and routes all human output (preflight, logs, summary) to stderr, so 'push ... --output-json | jq' is clean. Implies non-interactive. JSON is emitted at the dry-run stop (status=dry-run) and after submit (status=succeeded/failed/detached/unknown + summary counts). The wire shape (pushJSONResult/pushJSONSummary) lives in the CLI layer so submit.Summary stays json-tag-free. Adds printerForWriter for the stderr routing; unit-tested via TestWritePushJSON.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(#29): align --output-json status with exit code + emit JSON on errors

classifyPushOutcome maps submit.Run's result to a (status, exitError) pair in lockstep: JobOutcomeSucceeded + summary.HasFailures() now yields status "completed_with_failures" + exit 9 (was "succeeded" while exiting 9). --output-json now emits exactly one result object on EVERY path — including auth/submit/watch errors (with job namespace+name when available) — instead of nothing on error. Adds TestClassifyPushOutcome. Addresses Bugbot on #38.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…#41)

A leading ~ / ~/… in the dataset path now resolves under $HOME. The shell only expands an *unquoted* ~ on the command line; a path typed at the interactive prompt (#28) or a quoted/literal ~ positional arg reaches the CLI literally, and filepath.Abs would just prepend the CWD (.../cwd/~/...). Adds expandHome (mirrors cluster.expandPath) and applies it in runDatasetPush right after a.LocalPath is resolved — before any push.Discover* call — so both entry points are covered in one place. Relative/absolute/empty paths pass through untouched.

Deferred the optional in-prompt existence validator: it would couple the prompt-mapping unit tests to real directories on disk. Filed nothing — noted in the PR.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Adds 'tracebloc dataset rm <table>': the in-cluster teardown of a pushed dataset, packaging the manual kubectl-exec cleanup. Discovers the cluster (parent release + shared PVC), shows the teardown plan, confirms (reuses the #28 prompter; --yes to skip, --dry-run to preview), then DROPs the MySQL table (exec into the mysql pod, using its own $MYSQL_ROOT_PASSWORD so no credential transits the CLI) and rm -rf's the PVC dirs (exec into the jobs-manager pod). Exit codes mirror push (2 bad name, 3 kubeconfig/refused, 4 no release/PVC, 7 teardown failed).

Does NOT remove the central backend catalog entry — the CLI has no direct line to that backend; tracked as the cross-repo follow-up #39. The exec-into-pods mechanism (CLI-direct) vs a server-side jobs-manager delete endpoint is the open architecture question — see the DESIGN NOTE on push.Teardown. Hence: draft, pending team-lead review.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…m64 (#43)

Widen the release build matrix from 5 to 8 targets for the first stable
v0.1.0: add linux/386, linux/arm (GOARM=6, covers armv6 + armv7), and
windows/arm64. macOS amd64/arm64 and linux/windows amd64/arm64 unchanged.

- install.sh detect_arch: learn i386|i686 -> 386 and
  armv6l|armv7l|armv8l|armhf -> arm (else auto-install breaks on them).
- install.ps1 Get-Arch: return arm64 (was a hard fail) and prefer
  PROCESSOR_ARCHITEW6432 so x64-emulated PowerShell on a Windows-ARM host
  still picks the native arm64 build.
- README + RELEASE_CHECKLIST: reflect the 8-platform stable release; the
  releases/latest/download/install.sh one-liner now resolves (a plain
  v0.1.0 tag is non-prerelease per release.yml's gate, so it is `latest`).

Verified: all 8 targets cross-compile (CGO_ENABLED=0) to the right arch;
release.yml YAML + install.ps1 parse clean. No Go source changed.

Refs #42

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
…rompt examples (#44)

* feat(#31): friendlier dataset push — prose intro + guided 4-step flow

Replaces the terse bullet header with a plain-English explainer (grounded in docs.tracebloc.io: 'your workspace', 'the cluster your workspace was installed on', 'your data stays on that cluster'), via a new ui.Printer.Para for prose. Restructures the push into a clearly-numbered, narrated 4-step flow — Check your dataset / Connect to your cluster / Stage your files / Run the ingestion — each with a one-line how/why for medium-technical users (steps 1-2 visible in --dry-run, 3-4 live). Splits printPushPreflight into printLocalSummary + printClusterSummary so each sits under its step; the dry-run stop now names the live-only steps it skipped.

dataset rm: drop the backend-catalog clause from the runtime warning (now just 'Destructive and cannot be undone.'); --help NOTE + #39 tracking unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat(#31): per-prompt guidance + examples in interactive push

Each interactive input prompt now shows a visible hint with an example above it — previously this guidance was hidden behind survey's '?' key. Covers the core prompts (path, table, intent, label column) and the category-specific ones (keypoint count, image resolution, tabular schema, regression label-policy, time column). Rendered via a new ui.PromptHint: a leading blank line for separation + cyan text, so per-field guidance stands out and reads distinctly from the dim generic hints (e.g. the 'Press Enter' meta-line). Verified by TestRunInteractive_ShowsExampleHints, which drives runInteractive with a buffer-backed Printer — no TTY needed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
release.yml builds 8 targets but build.yml (PR CI) only compiled 5, so a
break in linux/386, linux/arm, or windows/arm64 wouldn't surface until a
release tag. Bring build.yml's matrix in lock-step: add linux/386,
linux/arm (GOARM=6), windows/arm64. Compile-only (the native linux/amd64
smoke step is unchanged).

Closes #45

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
The bare-'tracebloc' home screen now lists 'dataset rm' alongside push/cluster-info/ingest-validate. The rm command itself gains the same guidance treatment as push: a plain-English Para intro after the banner (what it removes — table + files — and that it can't be undone), and a cyan PromptHint above the confirmation. Home-screen test asserts 'dataset rm' appears.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@aptracebloc aptracebloc requested a review from saadqbal June 4, 2026 09:30
@aptracebloc aptracebloc self-assigned this Jun 4, 2026
@LukasWodka
Copy link
Copy Markdown
Contributor

👋 Heads-up — Code review queue is at 13 / 8

Above the WIP limit. The team convention is to review existing PRs before opening new work.

Open PRs currently in Code review (oldest first):

Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.)

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bf66d28. Configure here.

Comment thread internal/cli/dataset.go
Comment thread internal/push/teardown.go
- Status → v0.2.0 (latest stable; builds on v0.1.0 with the friendlier
  guided dataset push + dataset rm on the home screen).
- Reconcile the Roadmap: "Next (v0.2)" framed v0.2 as the cloud-sources
  milestone, but v0.2.0 ships UX polish — so cloud sources / segmentation
  / `list` move to a label-free "Next", and `rm` drops from the future
  verbs (it shipped in v0.1.0).
- Phase-5 table link pinned to the v0.1.0 tag (text said v0.1.0 but
  linked to /latest, which now resolves to v0.2.0).

Refs #48

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
- dataset push --output-json: emit a JSON error object on early-failure paths (validation, discovery, staging, token, port-forward), not just on dry-run/post-submit. runDatasetPush now uses a named return + a jsonEmitted flag + a defer, so '… --output-json | jq' always gets JSON instead of empty stdout on a failure. Adds Error/ExitCode to the result shape + writePushErrorJSON; covered by TestRunDatasetPush_OutputJSONEarlyFailureEmitsJSON.

- dataset rm: on a partial teardown (DROP TABLE succeeded but the PVC file removal failed), the error now says so and points the user to re-run — both teardown ops are idempotent (DROP TABLE IF EXISTS / rm -rf), so a re-run completes cleanup rather than reporting a flat 'teardown failed'.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@aptracebloc aptracebloc merged commit e81c78e into main Jun 4, 2026
26 of 27 checks passed
aptracebloc added a commit that referenced this pull request Jun 4, 2026
dataset list --output-json now emits a JSON error object on early-failure paths (kubeconfig, no parent release, cluster query), not just on success — mirroring the dataset push fix from #49. runDatasetList uses a named return + jsonEmitted flag + a defer; adds writeDatasetListErrorJSON. Covered by TestRunDatasetList_OutputJSONEarlyFailureEmitsJSON.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants