Skip to content

feat: home-screen polish — CTA spacing + flip the dataset push entry#56

Merged
aptracebloc merged 2 commits into
developfrom
feat/output-spacing
Jun 5, 2026
Merged

feat: home-screen polish — CTA spacing + flip the dataset push entry#56
aptracebloc merged 2 commits into
developfrom
feat/output-spacing

Conversation

@aptracebloc
Copy link
Copy Markdown
Contributor

@aptracebloc aptracebloc commented Jun 5, 2026

Two small home-screen / output polish changes.

1. Detach closing/CTA lines with a blank line

New ui.Printer.Newline() (emits one blank line), called above the lines that conclude or call to action so they don't get lost against the field/log block above:

  • cluster info — above ✔ Ready for tracebloc dataset push.
  • dataset push --dry-run — above ✔ Dry-run complete …
  • dataset rm — above ✔ Deleted …
  • dataset rm --dry-run — above ✔ Dry-run — nothing was deleted.
  • home screen — above the Add --help … footer

Not changed: the push ingestion summary (submit.go already emits that blank before RenderSummary); the cancel lines (left tight to the confirm prompt).

2. Flip the home-screen dataset push entry

Lead with the guided default rather than a flag example:

· tracebloc dataset push             — stage + ingest a dataset interactively (or use --help to see flags)

(was tracebloc dataset push ./data … (guided if you omit flags)). "interactively" echoes the tagline; bare command keeps the column aligned.

Verification

make ci green; confirmed live (line-numbered output shows the real blank lines; home screen shows the flipped, aligned push entry). Existing substring-based tests unaffected.

🤖 Generated with Claude Code


Note

Low Risk
Terminal formatting and help text only; no ingestion, cluster, or auth behavior changes.

Overview
Adds ui.Printer.Newline() so closing success lines and footers sit on a blank line after field blocks, and wires it into cluster info, dataset push / dataset rm dry-run and post-delete success paths, plus the bare tracebloc home screen before the --help hint.

Updates the home screen dataset push line to emphasize the interactive default (bare command, “interactively”, pointer to --help for flags) instead of ./data and “guided if you omit flags”.

Reviewed by Cursor Bugbot for commit 4539e5b. Bugbot is set up for automated code reviews on this repo. Configure here.

Adds ui.Printer.Newline() and inserts a blank line above the lines that conclude or call to action, so they don't get lost against the field block above: cluster info's '✔ Ready…' CTA, dataset push --dry-run result, dataset rm result + its --dry-run result, and the home-screen 'Add --help' footer. The push ingestion summary already gets a blank from submit.go (RenderSummary left untouched to avoid a double gap). Cancel lines left tight to their prompt by design.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@LukasWodka
Copy link
Copy Markdown
Contributor

👋 Heads-up — Code review queue is at 17 / 8

Above the WIP limit. The team convention is to review existing PRs before opening new work.

Open PRs currently in Code review (oldest first):

Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.)

@aptracebloc aptracebloc requested a review from saadqbal June 5, 2026 12:40
The 'Get started' entry for dataset push now shows the bare 'tracebloc dataset push' (the interactive/guided default) instead of leading with './data', and the comment points to --help for flags — interactively stage + ingest a dataset (or use --help to see flags). Bare command is 22 chars, so the — column stays aligned with the other entries.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@aptracebloc aptracebloc changed the title feat: detach closing/CTA lines with a blank line feat: home-screen polish — CTA spacing + flip the dataset push entry Jun 5, 2026
@aptracebloc aptracebloc merged commit 6e8b339 into develop Jun 5, 2026
13 checks passed
@aptracebloc aptracebloc self-assigned this Jun 5, 2026
@cursor cursor Bot mentioned this pull request Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants