feat: home-screen polish — CTA spacing + flip the dataset push entry#56
Merged
Conversation
Adds ui.Printer.Newline() and inserts a blank line above the lines that conclude or call to action, so they don't get lost against the field block above: cluster info's '✔ Ready…' CTA, dataset push --dry-run result, dataset rm result + its --dry-run result, and the home-screen 'Add --help' footer. The push ingestion summary already gets a blank from submit.go (RenderSummary left untouched to avoid a double gap). Cancel lines left tight to their prompt by design. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
👋 Heads-up — Code review queue is at 17 / 8 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
saadqbal
approved these changes
Jun 5, 2026
The 'Get started' entry for dataset push now shows the bare 'tracebloc dataset push' (the interactive/guided default) instead of leading with './data', and the comment points to --help for flags — interactively stage + ingest a dataset (or use --help to see flags). Bare command is 22 chars, so the — column stays aligned with the other entries. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small home-screen / output polish changes.
1. Detach closing/CTA lines with a blank line
New
ui.Printer.Newline()(emits one blank line), called above the lines that conclude or call to action so they don't get lost against the field/log block above:cluster info— above✔ Ready for tracebloc dataset push.dataset push --dry-run— above✔ Dry-run complete …dataset rm— above✔ Deleted …dataset rm --dry-run— above✔ Dry-run — nothing was deleted.Add --help …footerNot changed: the push ingestion summary (
submit.goalready emits that blank beforeRenderSummary); the cancel lines (left tight to the confirm prompt).2. Flip the home-screen
dataset pushentryLead with the guided default rather than a flag example:
(was
tracebloc dataset push ./data … (guided if you omit flags)). "interactively" echoes the tagline; bare command keeps the—column aligned.Verification
make cigreen; confirmed live (line-numbered output shows the real blank lines; home screen shows the flipped, aligned push entry). Existing substring-based tests unaffected.🤖 Generated with Claude Code
Note
Low Risk
Terminal formatting and help text only; no ingestion, cluster, or auth behavior changes.
Overview
Adds
ui.Printer.Newline()so closing success lines and footers sit on a blank line after field blocks, and wires it intocluster info,dataset push/dataset rmdry-run and post-delete success paths, plus the baretraceblochome screen before the--helphint.Updates the home screen
dataset pushline to emphasize the interactive default (bare command, “interactively”, pointer to--helpfor flags) instead of./dataand “guided if you omit flags”.Reviewed by Cursor Bugbot for commit 4539e5b. Bugbot is set up for automated code reviews on this repo. Configure here.