Skip to content

Remove REQUESTS_PROXY_ADMIN_TOKEN#120

Merged
saqlainsyed007 merged 1 commit into
developfrom
request-proxy
May 13, 2026
Merged

Remove REQUESTS_PROXY_ADMIN_TOKEN#120
saqlainsyed007 merged 1 commit into
developfrom
request-proxy

Conversation

@saqlainsyed007
Copy link
Copy Markdown

@saqlainsyed007 saqlainsyed007 commented May 13, 2026

Summary

Removes REQUESTS_PROXY_ADMIN_TOKEN — a Kubernetes Secret, env var injection, and chart value that were never consumed by any runtime code. The requests-proxy server has no admin HTTP API (only pod-facing /v1/result and /v1/flops routes); token validation is handled via per-job Bearer tokens from MySQL. The jobs-manager similarly never reads this env var.

Related

Ref tracebloc/client-runtime#33

Type of change

  • Tech-debt / refactor
  • Security / hardening

Test plan

  • helm unittest client/ — 116/116 passing (updated document-count assertions in node_agents_namespace_test.yaml to reflect the removed secret)
  • Verified in tracebloc/client-runtime that requests_proxy_server.py and jobs_manager.py have no references to REQUESTS_PROXY_ADMIN_TOKEN

Deployment notes

The {{ .Release.Name }}-requests-proxy-admin Secret will no longer be created on fresh installs. On existing clusters, the orphaned Secret can be deleted manually:

kubectl delete secret <release-name>-requests-proxy-admin -n <namespace>

No rollout order dependency — neither container reads this env var.

Checklist

  • Tests added / updated and passing locally
  • Docs updated if behavior or config changed
  • No secrets / credentials in the diff
  • For security-sensitive paths: appropriate reviewer requested

@saqlainsyed007 saqlainsyed007 requested a review from saadqbal as a code owner May 13, 2026 08:56
@saqlainsyed007 saqlainsyed007 merged commit 0fe120e into develop May 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants