Skip to content

fix: nil-guard ingestionAuthz access for --reuse-values upgrade path #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saadqbal merged 1 commit into from
May 18, 2026
+11 −1
Merged

fix: nil-guard ingestionAuthz access for --reuse-values upgrade path #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion client/templates/ingestion-authz-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,17 @@ metadata:
data:
ingestion-authz.yaml: |
allowed:
{{- range .Values.ingestionAuthz.allowed }}
{{- /*
Nil-guarded chain: an upgrade with `--reuse-values` from a
pre-#123 release won't have `.Values.ingestionAuthz` in its
stored values, and an unguarded `.Values.ingestionAuthz.allowed`
crashes with "nil pointer evaluating interface {}.allowed".
`default dict` + `default list` collapse the missing parent /
missing child to an empty list, which renders as `allowed: []`
— fail-safe (the authz policy then denies every caller, which
is correct: there's no policy until the operator sets one).
*/ -}}
{{- range default list (default dict .Values.ingestionAuthz).allowed }}
- service_account: {{ .service_account | quote }}
namespace: {{ .namespace | default $.Release.Namespace | quote }}
table_prefixes:
Expand Down
Loading