fix(chart): bump default ingestor tag 0.3 → 0.5#314
Merged
Conversation
jobs-manager validates ingest.yaml at submit time against a schema that now tracks data-ingestors' newer categories (sentence_pair_classification, embeddings, seq2seq, causal_language_modeling — client-runtime#162). Those first ship in the ingestor 0.5 line (v0.5.6); the 0.3 float tag only supports 11 categories. Leaving the spawned ingestor on 0.3 while the submit schema accepts 15 re-opens the submit-vs-run drift bug: a customer submitting one of the new categories passes validation, a Job is minted, and the 0.3 image can't process it. Point the default float tag at the 0.5 line so the spawned ingestor supports the full catalogue the schema accepts. `0.5` auto-tracks 0.5.x patches (imagePullPolicy=Always); a future 0.6 needs an explicit bump. - values.yaml: images.ingestor.tag 0.3 -> 0.5 (+ rationale comment). - jobs-manager-deployment.yaml: --reuse-values nil-guard fallback 0.3 -> 0.5 so a pre-images.ingestor-key release upgraded with --reuse-values doesn't silently fall back to the drifting 0.3. - jobs_manager_test.yaml: default-wiring assertion 0.3 -> 0.5. Verified: `helm template` renders INGESTOR_IMAGE_TAG "0.5" on both the default and nil-guard paths. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
saadqbal
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the default spawned-ingestor float tag
images.ingestor.tagfrom0.3→0.5.Why
jobs-manager validates every
ingest.yamlat submit time against a vendored schema that now tracks data-ingestors' newer task categories —sentence_pair_classification,embeddings,seq2seq,causal_language_modeling(client-runtime#162). Those categories first ship in the ingestor 0.5 line (v0.5.6); the0.3float tag resolves to the latest0.3.x(v0.3.12), which supports only 11 categories.Leaving the spawned ingestor on
0.3while submit-time validation accepts 15 re-opens the submit-vs-run drift bug (the #64 class): a customer submitting one of the new categories passes validation, a Job is minted, and the0.3image can't process it. This was found while triaging review comments on client-runtime#161 — dev, staging, and prod all pin0.3.Changes
values.yaml—images.ingestor.tag0.3→0.5, with a rationale comment.0.5auto-tracks0.5.xpatches (imagePullPolicy=Always); a future0.6needs an explicit bump, same convention as before.templates/jobs-manager-deployment.yaml— the--reuse-valuesnil-guard fallbackdefault "0.3"→default "0.5", so upgrading a release that predates theimages.ingestorkey doesn't silently fall back to the drifting0.3.tests/jobs_manager_test.yaml— default-wiring assertion0.3→0.5.Verification
helm templaterendersINGESTOR_IMAGE_TAG: "0.5"on both the default path and the nil-guard (images.ingestor=null) path.Before merge / deploy — please confirm
ghcr.io/tracebloc/ingestor:0.5exists and is a multi-arch index (amd64+arm64). Perrelease-image.ymlthev0.5.xreleases publish the:0.5float tag; the chart'singestor-multiarchCI job enforces the multi-arch requirement. (I couldn't list ghcr tags directly — the CLI token lacksread:packages.)Related
🤖 Generated with Claude Code
Note
Medium Risk
Changes which container image runs for all default ingestion Jobs; wrong or missing
ghcr.io/tracebloc/ingestor:0.5would break ingestion fleet-wide, but scope is a version bump aligned with runtime schema—not auth or data-path logic.Overview
Aligns the chart’s default spawned ingestor with jobs-manager validation by changing
images.ingestor.tagfrom0.3to0.5, with comments explaining that newer task categories (e.g.sentence_pair_classification, embeddings) ship on the 0.5 line while 0.3 only covered 11 categories.The jobs-manager deployment template’s nil-guard fallback for
INGESTOR_IMAGE_TAGis updated the same way (0.3→0.5), so upgrades with--reuse-valueson releases that lackimages.ingestorno longer silently schedule the old 0.3 image. The Helm unit test for default ingestor wiring expects0.5instead of0.3.Reviewed by Cursor Bugbot for commit 7268b24. Bugbot is set up for automated code reviews on this repo. Configure here.