Conversation
- Changed the installation method for k3d to download the script to a temporary file before executing, enhancing security and reliability. - Added a check to ensure the k3d binary is executable after installation, improving usability.
- Eliminated the check for setting executable permissions on the k3d binary, as it is no longer necessary with the updated installation method. - This change streamlines the installation process and reduces potential errors related to file permissions.
- Adjusted umask to 022 temporarily while installing system tools to ensure proper executable permissions for binaries in /usr/local/bin/. - Restored the original umask after installations to maintain security settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches the Linux bootstrap path and changes how privileged installs run (downloaded installer script execution and
umaskhandling), which could break tool installation or permissions across distros.Overview
The Linux setup script now installs
k3dby downloading the upstream installer to a temporary file with retries and running it viasudo, instead of pipingcurldirectly intobash.It also temporarily relaxes the process
umaskto022while installingkubectl/k3d/helm(restoring it afterward) so binaries placed in/usr/local/binaren’t left executable only by root under the default hardenedumask 077.Written by Cursor Bugbot for commit 69c6692. This will update automatically on new commits. Configure here.