fix(ci): pass CI values file to release lint so --strict passes#62
Merged
fix(ci): pass CI values file to release lint so --strict passes#62
Conversation
The release workflow's `helm lint --strict ./client` step was running without a values file. Schema enforces minLength:1 on clientId and clientPassword; the defaults in values.yaml are deliberately empty (forcing operators to supply real credentials). Result: strict lint always failed, and no release since the schema constraint was added has published — this is why 1.0.4, 1.0.5, 1.0.6, 1.0.7 never reached gh-pages. Mirror helm-ci.yaml's approach and pass `-f client/ci/eks-values.yaml` (which sets ci-test credentials) so the chart lints cleanly for packaging. Exhaustive multi-platform linting continues to run in helm-ci.yaml on every PR.
saqlainsyed007
approved these changes
Apr 24, 2026
saadqbal
added a commit
that referenced
this pull request
Apr 24, 2026
Merge pull request #62 from tracebloc/fix/release-workflow-lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release workflow's
helm lint --strict ./clientstep was running without a values file. The schema enforcesminLength: 1onclientId/clientPassword; the defaults invalues.yamlare deliberately empty (forcing operators to supply real credentials). Result: strict lint has been failing on every release run, and no tagged release since the schema constraint was added has successfully published. This is why chart versions 1.0.4, 1.0.5, 1.0.6, and 1.0.7 never reachedgh-pages/ the public Helm repo.Fix
Mirror helm-ci.yaml's approach — pass
-f client/ci/eks-values.yaml(which shipsci-test-id/ci-test-password) so strict lint sees valid credentials. Exhaustive multi-platform linting continues to run inhelm-ci.yamlon every PR; release lint just needs the chart to pass for packaging.Test plan
helm lint --strict ./client -f client/ci/eks-values.yaml→ 1 chart linted, 0 failedv1.0.8tag and confirm the release workflow publishesclient-1.0.8.tgztogh-pagesFollow-up
After merge + tag, a manual mirror step is still required: copy
client-1.0.8.tgz+ regeneratedindex.yamlfrom this repo'sgh-pagestotracebloc/client'sgh-pages, sincescripts/install-k8s.shreads from the latter.Note
Low Risk
Low risk: only adjusts the release GitHub Actions workflow lint command, with no runtime/chart template changes; main risk is an incorrect values path could still fail releases.
Overview
Fixes the Helm chart release workflow failing
helm lint --strictby running lint with a CI values file (client/ci/eks-values.yaml) so requiredclientId/clientPasswordschema constraints are satisfied during packaging.Adds inline documentation clarifying that exhaustive linting remains in
helm-ci.yaml, while the release workflow just needs a clean strict lint before publishing.Reviewed by Cursor Bugbot for commit 0d0804d. Bugbot is set up for automated code reviews on this repo. Configure here.