Skip to content

Prod: Revert CODEOWNERS to maintain narrow security rules #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saadqbal merged 2 commits into from
Apr 30, 2026
Merged

Prod: Revert CODEOWNERS to maintain narrow security rules #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72052aa
chore: revert default CODEOWNERS — keep narrow security rules only (#92)
LukasWodka Apr 30, 2026
d0a6925
Merge pull request #91 from tracebloc/chore/bump-chart-1.3.1
saadqbal Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
# Default reviewer: each PR auto-requests the squad lead listed here.
# Either reviewer can approve to satisfy branch protection (1 approval required).
# Specific paths below override this default for security-sensitive code.
# Narrow CODEOWNERS — security backstop only.
# Author picks reviewers for everything else.

* @saadqbal @saqlainsyed007

# === Narrow security CODEOWNERS (preserved from prior PRs) ===
Copy link
Copy Markdown

@cursor cursor Bot Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODEOWNERS does not protect itself or CI workflows

High Severity

Removing the wildcard * rule without adding a rule for .github/ leaves the CODEOWNERS file itself and all .github/workflows/ (including release-helm-chart.yaml) unprotected. A contributor can now submit a PR that modifies CODEOWNERS to remove the remaining security-sensitive path rules, or alter CI workflows to exfiltrate secrets, without triggering any required CODEOWNERS review. This undermines the stated goal of maintaining a "security backstop."

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d0a6925. Configure here.

/client/templates/ @saadqbal
/client/values.schema.json @saadqbal
/client/values.yaml @saadqbal
Expand Down
4 changes: 2 additions & 2 deletions client/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ apiVersion: v2
name: client
description: A unified Helm chart for tracebloc on AKS, EKS, bare-metal, and OpenShift
type: application
version: 1.3.0
appVersion: "1.3.0"
version: 1.3.1
appVersion: "1.3.1"
keywords:
- tracebloc
- kubernetes
Expand Down
4 changes: 4 additions & 0 deletions client/MIGRATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ Releases of 1.3.0+ install a `<release>-auto-upgrade` CronJob that polls
published. This closes [tracebloc/client#69](https://github.com/tracebloc/client/issues/69) —
older deployed clients stop drifting from the latest secure / stable release.

> **Verified end-to-end on `tb-client-dev-templates` during the 1.3.1 release**:
> a `tracebloc` release at 1.3.0 self-upgraded to 1.3.1 within a single
> CronJob tick after publish, with no operator intervention.

> **Operator note for the 1.x → 1.3.0 jump.** Use `--reset-then-reuse-values`
> on the *manual* upgrade command too, not plain `--reuse-values`. The new
> `autoUpgrade` block was added in 1.3.0; with `--reuse-values` Helm reuses
Expand Down
Loading