Skip to content

Comments

Add .d_input()/.d_output() methods to Linear#2929

Closed
crutcher wants to merge 2 commits intotracel-ai:mainfrom
crutcher:crutcher/linear
Closed

Add .d_input()/.d_output() methods to Linear#2929
crutcher wants to merge 2 commits intotracel-ai:mainfrom
crutcher:crutcher/linear

Conversation

@crutcher
Copy link
Contributor

@crutcher crutcher commented Mar 20, 2025

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Changes

Added in/out introspection methods to Linear;
so assertions can be written relative to Linear's configs,
rather than reaching into the .weights.dim()[] manually.

Testing

Wrote a test.

@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.13%. Comparing base (26269a6) to head (d1028cc).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2929   +/-   ##
=======================================
  Coverage   82.13%   82.13%           
=======================================
  Files         866      866           
  Lines      120052   120071   +19     
=======================================
+ Hits        98603    98619   +16     
- Misses      21449    21452    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@laggui
Copy link
Member

laggui commented Mar 26, 2025

Closing this for now following our previous discussion on discord 🙂

@laggui laggui closed this Mar 26, 2025
@crutcher crutcher deleted the crutcher/linear branch April 28, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants