Add .d_input()/.d_output() methods to Linear#2929
Closed
crutcher wants to merge 2 commits intotracel-ai:mainfrom
Closed
Add .d_input()/.d_output() methods to Linear#2929crutcher wants to merge 2 commits intotracel-ai:mainfrom
crutcher wants to merge 2 commits intotracel-ai:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2929 +/- ##
=======================================
Coverage 82.13% 82.13%
=======================================
Files 866 866
Lines 120052 120071 +19
=======================================
+ Hits 98603 98619 +16
- Misses 21449 21452 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Closing this for now following our previous discussion on discord 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed.Changes
Added in/out introspection methods to Linear;
so assertions can be written relative to Linear's configs,
rather than reaching into the
.weights.dim()[]manually.Testing
Wrote a test.