-
Notifications
You must be signed in to change notification settings - Fork 48
doc: fix typo in example TS snippet #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix typo in typescript function
WalkthroughThe TypeScript snippet in Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Reader as Docs Reader
participant File as `introduction.mdx`
participant Snippet as TypeScript Snippet
Note over File,Snippet: Edit: change method signature to include body
Reader->>File: Open docs
File->>Snippet: Render TypeScript example
Snippet->>Reader: Shows `async create_joke() { ... }`
Note right of Reader: Snippet now contains a function body token
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks (3 passed)✅ Passed checks (3 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to d1e94cc in 42 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. openllmetry/introduction.mdx:50
- Draft comment:
Fixed TS syntax: replaced colon with '{' in function declaration. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, stating what was changed without providing any actionable feedback or suggestions. It doesn't ask for confirmation or suggest improvements.
2. openllmetry/introduction.mdx:51
- Draft comment:
Declare 'completion' with 'const' to prevent accidental global variable usage. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_KlMNC1upcXI3B4KD
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
openllmetry/introduction.mdx (1)
49-57: Fix invalid TS snippet: declarecompletionand close the class.Currently
completionis implicitly global/undefined and the class is missing its closing brace.Apply:
class MyLLM { @traceloop.workflow("joke_creation") async create_joke() { - completion = await openai.chat.completions.create({ + const completion = await openai.chat.completions.create({ model: "gpt-3.5-turbo", messages: [{"role": "user", "content": "Tell me a joke about opentelemetry"}], }) return completion.choices[0].message.content } +}
🧹 Nitpick comments (1)
openllmetry/introduction.mdx (1)
41-41: Use TypeScript syntax highlighting.Change the fence to
tsfor proper highlighting in docs.Example:
```ts Typescript // ...</blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used**: CodeRabbit UI **Review profile**: CHILL **Plan**: Pro **💡 Knowledge Base configuration:** - Linear integration is disabled by default for public repositories You can enable these sources in your CodeRabbit configuration. <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between fae41a25691f2d1fb6a69f0c15023cb78ead73ad and d1e94cc484673126dc930a020ac8af5c88880d08. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `openllmetry/introduction.mdx` (1 hunks) </details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
nirga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! @dilawar
Fix typo in typescript function
Important
Fixes syntax error in TypeScript snippet in
introduction.mdxby replacing:with{increate_joke()function.introduction.mdxby replacing:with{increate_joke()function.This description was created by
for d1e94cc. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit