Update repo to follow Gem development conventions#11
Merged
nirga merged 1 commit intotraceloop:mainfrom Jul 19, 2024
Merged
Conversation
ABizzinotto
approved these changes
Jul 18, 2024
nirga
reviewed
Jul 19, 2024
Member
nirga
left a comment
There was a problem hiding this comment.
Thanks @JaredShay, I'm not sure I completely understood the rational behind this - mind explaining?
Contributor
Author
Yes, apologies. I pushed this up quickly while bundling the repo and never updated the description. The PR now has a description and reasoning behind each change. |
nirga
approved these changes
Jul 19, 2024
Member
nirga
left a comment
There was a problem hiding this comment.
Thanks so much for this! I'm a bit rusty on Ruby from my days at Fiverr 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a few quick updates from bundling the repo locally.
gemspecto the repository gem's Gemfiles.bundle installby contributors. The docs for the method can be found here.gitignoreThese conventions follow what is outlined in https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/.