Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughStandardize calls to wrap_function_wrapper to use positional arguments across Agno and Langchain instrumentations; also change langchain_openai uninstrument targets to BaseChatOpenAI._generate/_agenerate. ChangesInstrumentation wrap_function_wrapper refactor (Agno & Langchain)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
thank you I hope this will be released soon I will cancel my pr 👍 |
…pt v1/v2 compat, fix BaseChatOpenAI uninstrument
eecc00e to
f935608
Compare
|
Hey, thx for the fix! Do you have any schedule to deploy this? |
Fixes #4009 — LangChain init crash: wrap_function_wrapper() got unexpected keyword argument 'module' when using wrapt v2
Also fixes a pre-existing bug where _uninstrument() was unwrapping BaseOpenAI instead of BaseChatOpenAI in langchain_openai.chat_models.base, meaning those wrappers were never actually removed on uninstrument.
Summary by CodeRabbit
New Features
Bug Fixes
Improvements