This repository was archived by the owner on Oct 24, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
support Global exception for NotFound and Operational Sqlalchemy Error #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 167
💛 - Coveralls |
Merged
buxx
suggested changes
Jun 1, 2018
tracim/__init__.py
Outdated
| ) | ||
| context = PyramidContext( | ||
| configurator=configurator, | ||
| default_error_builder=ErrorSchema() |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@inkhey Can you activate debug mode if tracim is run in debug mode ?
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
lebouquetin
suggested changes
Jun 1, 2018
tracim/__init__.py
Outdated
| ) | ||
| context = PyramidContext( | ||
| configurator=configurator, | ||
| default_error_builder=ErrorSchema() |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need algoo/hapic#49 (probably in hapic 0.40)
closes #59
Add support for NotFound and Operational Error (Sqlalchemy) Exception by hapic for all requests.
Those error as not as clear as it should be, we need to fix this later, see #76