Skip to content
This repository was archived by the owner on Oct 24, 2018. It is now read-only.

Conversation

@inkhey
Copy link
Contributor

@inkhey inkhey commented May 17, 2018

need algoo/hapic#49 (probably in hapic 0.40)
closes #59

Add support for NotFound and Operational Error (Sqlalchemy) Exception by hapic for all requests.
Those error as not as clear as it should be, we need to fix this later, see #76

@coveralls
Copy link

coveralls commented May 24, 2018

Pull Request Test Coverage Report for Build 167

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • 57 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.5%) to 75.407%

Files with Coverage Reduction New Missed Lines %
tracim/views/core_api/session_controller.py 2 100.0%
tracim/lib/utils/authorization.py 2 47.22%
tracim/command/webdav.py 4 66.67%
tracim/init.py 4 91.84%
tracim/lib/webdav/middlewares.py 12 16.67%
tracim/lib/webdav/init.py 16 56.58%
tracim/lib/utils/request.py 17 69.23%
Totals Coverage Status
Change from base Build 102: 0.5%
Covered Lines: 3980
Relevant Lines: 5278

💛 - Coveralls

@inkhey inkhey changed the title WIP: support Global exception for NotFound and Operational Sqlalchemy Error support Global exception for NotFound and Operational Sqlalchemy Error May 25, 2018
@inkhey inkhey mentioned this pull request May 28, 2018
)
context = PyramidContext(
configurator=configurator,
default_error_builder=ErrorSchema()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@inkhey Can you activate debug mode if tracim is run in debug mode ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

)
context = PyramidContext(
configurator=configurator,
default_error_builder=ErrorSchema()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lebouquetin lebouquetin merged commit a0ad204 into develop Jun 4, 2018
@inkhey inkhey deleted the fix/59_global_exception_handling branch July 17, 2018 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for global error code : 404, 500, ... with Hapic

5 participants