Skip to content

ENH PHP 8.1 compatibility#5

Merged
tractorcow merged 1 commit intotractorcow:masterfrom
creative-commoners:pulls/master/php81
Apr 25, 2022
Merged

ENH PHP 8.1 compatibility#5
tractorcow merged 1 commit intotractorcow:masterfrom
creative-commoners:pulls/master/php81

Conversation

@emteknetnz
Copy link
Copy Markdown
Contributor

@emteknetnz emteknetnz marked this pull request as ready for review April 20, 2022 05:11
Copy link
Copy Markdown
Contributor

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity: See discussion in silverstripe/silverstripe-admin#1294 about the general approach. tl;dr:

the purposes of this PR is to avoid passing null (specifically null) from built-in functions that as of php 8.1 will throw deprecation warnings if null is passed in. The approach is necessarily heavy-handed, and while there are many situations where it isn't needed, it would be prohibitively laborious to find all of those situations by hand.

Looks good to me, though I don't have access to merge this one.

@tractorcow tractorcow merged commit 3c05e96 into tractorcow:master Apr 25, 2022
@emteknetnz emteknetnz deleted the pulls/master/php81 branch April 25, 2022 23:46
@tractorcow
Copy link
Copy Markdown
Owner

I've tagged 1.0.0 fyi

@emteknetnz
Copy link
Copy Markdown
Contributor Author

@tractorcow any chance you could tag 0.1.3? - proxy-db requires ^0.1.1 https://github.com/tractorcow/silverstripe-proxy-db/blob/master/composer.json

@emteknetnz
Copy link
Copy Markdown
Contributor Author

@tractorcow I've opened up a subsequent pull-request on proxy-db to require ^1 of classproxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants