Include traded_market_ids in Portfolio for reliable history loading#372
Merged
Include traded_market_ids in Portfolio for reliable history loading#372
Conversation
The performance page needs to know which markets an account has ever traded/redeemed in order to request full trade history. Previously it only discovered markets from current portfolio exposure or already-loaded trades, missing closed positions and historical redemptions. Add a `traded_market_ids` field to the Portfolio proto, populated from a UNION query over trade and redemption tables during initial data send. The frontend stores these per-account and uses them to drive GetFullTradeHistory requests. Also fixes redeem fee double-counting in per-market filtered PnL views.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
traded_market_idsfield to the Portfolio proto, populated via a UNION query overtradeandredemptiontables during initial data sendGetFullTradeHistoryrequests on the performance pageTest plan