Skip to content

Fix transfer destination not showing other users when acting as#377

Merged
briansmiley merged 1 commit intomainfrom
fix-transfer-destination
Apr 11, 2026
Merged

Fix transfer destination not showing other users when acting as#377
briansmiley merged 1 commit intomainfrom
fix-transfer-destination

Conversation

@crthpl
Copy link
Copy Markdown
Contributor

@crthpl crthpl commented Mar 9, 2026

Summary

  • When a Sudoer acts as another account, the transfer form's Destination field was not showing "Other Users" because otherToAccounts compared fromAccountId against serverState.userId (the admin's own ID) instead of serverState.effectiveUserId (the acted-as user's ID)

Test plan

  • Log in as admin, act as another user account
  • Open the transfer form from that user's main account
  • Verify "Other Users" now appears in the Destination field

…er account

When a Sudoer acts as another account, the transfer form compared
fromAccountId against serverState.userId (the admin's own ID) instead
of serverState.effectiveUserId (the acted-as user's ID), preventing
"Other Users" from appearing in the Destination field.
@crthpl crthpl requested a review from a team as a code owner March 9, 2026 18:16
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
platform Ready Ready Preview, Comment Mar 9, 2026 6:17pm

Request Review

@briansmiley briansmiley merged commit b200854 into main Apr 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants