Skip to content

Comments

fix: traceability of the middleware plugins#10028

Merged
traefiker merged 1 commit intotraefik:v2.10from
ldez:fix/traceable-plugins
Jul 20, 2023
Merged

fix: traceability of the middleware plugins#10028
traefiker merged 1 commit intotraefik:v2.10from
ldez:fix/traceable-plugins

Conversation

@ldez
Copy link
Contributor

@ldez ldez commented Jul 19, 2023

What does this PR do?

Wraps plugins of middleware to be traceable like the internal middleware.

Motivation

Every middleware should be traceable.

More

  • Added/updated tests
  • Added/updated documentation

Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the fix/traceable-plugins branch from 2908e60 to 16da083 Compare July 20, 2023 12:40
@traefiker traefiker merged commit 47faae2 into traefik:v2.10 Jul 20, 2023
@ldez ldez deleted the fix/traceable-plugins branch July 20, 2023 13:14
@rtribotte rtribotte added the kind/bug/fix a bug fix label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants