Fix preflight response status in access logs #10142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
contributor/waiting-for-corrections
and removed
contributor/waiting-for-corrections
labels
Member
Author
|
@ldez Indeed, this was due to a typo in the test fixture. |
traefiker
force-pushed
the
fix-accesslogs-preflight-resp-status
branch
from
4fdabc0 to
25e5558
Compare
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds an explicit
WriteHeadercall in case of a response to a preflight request for the access status code probe to be able to catch it.Motivation
fixes #10064
More
Additional Notes
Co-authored-by: lbenguigui lbenguigui@gmail.com