Update github.com/hashicorp/consul/api #10220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpollet
added
status/2-needs-review
area/provider/consul
kind/bug/fix
kevinpollet
force-pushed
the
update-consul
branch
from
9a73651 to
1928784
Compare
kevinpollet
changed the title
kevinpollet
force-pushed
the
update-consul
branch
3 times, most recently
from
fc6ff01 to
6ca651e
Compare
traefiker
force-pushed
the
update-consul
branch
from
6ca651e to
19da9ca
Compare
rtribotte
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request updates the github.com/hashicorp/consul/api dependency to hashicorp/consul@api/v1.24.0...api/v1.26.1 and removes the consul dependency.
The consul dependency was only used to compute the SpiffeID. Furthermore, in newer version of this library, the computed SpiffeID will not be the same for Enterprise and CE builds (i.e. for CE builds the Namespace is always ignored and set to
default).Motivation
Because of the number of issues related to CVEs reported by scanning tools, we are updating the consul api dependency and removing the consul dependency.
Please note that Traefik is not affected by those CVEs. They affect the server code of the library, and Traefik is only using the client code.
More
Additionals Information
Co-authored-by: lbenguigui lbenguigui@gmail.com