Skip to content

Conversation

@0anas01
Copy link
Contributor

@0anas01 0anas01 commented May 16, 2024

What does this PR do?

This PR is documentation fix for Traefik v2 to v3 migration guide.

Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @0anas01, thanks a lot for this first step. We need a few more changes on this section, we will get back to you ASAP once we have the complete plan.

@0anas01
Copy link
Contributor Author

0anas01 commented May 29, 2024

How about we keep the configuration changes on a separate page and link to it in the migration guide?

@nmengin nmengin requested review from emilevauge and kevinpollet June 5, 2024 08:59
@emilevauge
Copy link
Member

How about we keep the configuration changes on a separate page and link to it in the migration guide?

I haven't seen this comment before, but this could simplify the structure of this documentation. I would vote for it.

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @0anas01 :)

@traefiker traefiker force-pushed the update_migration_guide branch from e2e8fde to 9d4b67e Compare June 6, 2024 13:04
@traefiker traefiker merged commit 359477c into traefik:v3.0 Jun 6, 2024
@0anas01 0anas01 deleted the update_migration_guide branch June 15, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants