Fix service name label_replace in Grafana #10758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hello @xdavidwu, Thanks for your contribution. Could you please rebase your PR on branch v2.11? |
mmatur
added
status/2-needs-review
kind/bug/fix
Contributor
Author
This issue only exists on branch v3.0 and master. Which one should I target? |
Member
|
Oops my bad, you can target |
xdavidwu
force-pushed
the
kubernetes-dashboard-fix-name-extraction
branch
from
7e706dc to
ec320fb
Compare
The kubernetes (ingress) provider create services named `<namespace>-<service name>-<port>`, other kubernetes providers (crd, gateway) also name their services in similiar fashion, combining names from kubernetes with '-'. Most kubernetes resources requires their name to be usable as dns subdomain names only, therefore '-' is also possible in names (actually quite common, like kube-system, kube-controller-manager). label_replace here before extracts first two part seperated with '-'. The intention here is probably to extract `<namespace>-<service name>`, but with '-' in namespaces or service names, this breaks and usually generates labels that are not unique. If there are query operation after label_replace, it is also fragile, due to having multiple series with same labels. This fixes it by removing only `@<providername>` instead. '@' is invalid for names in most kubernetes resources, so this should be safe.
kevinpollet
force-pushed
the
kubernetes-dashboard-fix-name-extraction
branch
from
ec320fb to
58ac35b
Compare
kevinpollet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kubernetes (ingress) provider create services named
<namespace>-<service name>-<port>, other kubernetes providers (crd, gateway) also name their services in similiar fashion, combining names from kubernetes with '-'. Most kubernetes resources requires their name to be usable as dns subdomain names only, therefore '-' is also possible in names (actually quite common, like kube-system, kube-controller-manager).label_replace here before extracts first two part seperated with '-'. The intention here is probably to extract
<namespace>-<service name>, but with '-' in namespaces or service names, this breaks and usually generates labels that are not unique. If there are query operation after label_replace, it is also fragile, due to having multiple series with same labels.This fixes it by removing only
@<providername>instead. '@' is invalid for names in most kubernetes resources, so this should be safe.What does this PR do?
Fix service name extraction on dashboard for traefik on kubernetes.
Motivation
More
Additional Notes