Skip to content

Conversation

@peacewalker122
Copy link
Contributor

What does this PR do?

Modification on certificatesDuration docs. Basically add information to tell that option was for duration for the issued certificate from their certificate authority will last.

Motivation

Issue #10847

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@kevinpollet
Copy link
Member

kevinpollet commented Jul 22, 2024

Hello @peacewalker122 and thanks for your contribution,

As this pull request is a bug fix, please could you rebase it on branch v2.11?

@kevinpollet kevinpollet changed the title modify certificatesDuration docs Modify certificatesDuration documentation Jul 22, 2024
@peacewalker122
Copy link
Contributor Author

sure @kevinpollet

@rtribotte rtribotte changed the base branch from master to v2.11 July 22, 2024 14:34
@kevinpollet
Copy link
Member

Hello @peacewalker122,

Something was wrong during the rebase, so I rebased it again.

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants