-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Add 30 day certificatesDuration step #10970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @luker983, Thanks for opening this pull request! We have marked thus as a |
|
After a second though, I moved it to `needs-review' because I actually think this is a good enhancement, that modifies the renewal mechanism, but in a way that should be harmless and beneficial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
kevinpollet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
What does this PR do?
Adds a new
certificatesDurationthreshold, setting renew period and renew interval to 10 days and 12 hours respectively when 30 days <=certificatesDuration< 90 days.Motivation
There is a large gap between the 7 and 90 day
certificatesDurationthresholds that has made Traefik difficult to adopt in environments that issue certificates with lifetimes shorter than 90 days.With the current thresholds, 7-30 day cert lifetimes must either renew daily (straining the ACME CA), or only on the day before expiry (leaving little time to resolve an issue if renewal fails)
More
Additional Notes
Ideally the renewal values would be directly configurable as they are in most ACME clients, but I understand the desire for a simpler config. If maintainers are up for opening that discussion again I would prefer to go that route 😄