Skip to content

Unify tab titles#11072

Merged
traefiker merged 2 commits intotraefik:v2.11from
jsoref:unify-tab-titles
Sep 9, 2024
Merged

Unify tab titles#11072
traefiker merged 2 commits intotraefik:v2.11from
jsoref:unify-tab-titles

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Sep 4, 2024

What does this PR do?

Unifies tab titles in docs.

Motivation

Each of these exists, often in the same file...

  • tab="Kubernetes IngressRoute"

  • tab="IngressRoute"

  • tab="K8s IngressRoute"

  • tab="K8s Ingress"

  • tab="Kubernetes Ingress"

  • tab="Ingress"

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

I'm willing to change things in the other direction (to K8s or Kubernetes) if that's preferable...

@mmatur
Copy link
Member

mmatur commented Sep 5, 2024

Thanks for your contribution @jsoref could you please rebase your PR on branch v2.11

If it's desired, then either `Kubernetes` or `K8s` could be applied
consistently to all tabs.

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
If it's desired, then either `Kubernetes` or `K8s` could be applied
consistently to all tabs.

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref jsoref changed the base branch from master to v2.11 September 5, 2024 12:55
@jsoref
Copy link
Contributor Author

jsoref commented Sep 5, 2024

@mmatur I hope this is what you wanted

@mmatur mmatur added this to the 2.11 milestone Sep 5, 2024
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit be5c429 into traefik:v2.11 Sep 9, 2024
@jsoref jsoref deleted the unify-tab-titles branch September 9, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants