Use correct default weight in Accept-Encoding #11084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youkoulayley
added
status/2-needs-review
kind/bug/fix
mmatur
approved these changes
Oct 8, 2024
Member
mmatur
left a comment
mmatur
left a comment
There was a problem hiding this comment.
LGTM
Thanks @michelheusschen 👍🏼
traefiker
force-pushed
the
acceptencoding-correct-weight
branch
from
60f467f to
63a4023
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support for weights in the
Accept-Encodingheader was added to the compression middleware in #10777. However, the default weight is set to0while RFC 9110 says: If no "q" parameter is present, the default weight is 1.This leads to inconsistent selection of the content encoding, see this example:
More