-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Send request body to authorization server for forward auth #11097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @kyo-ke, thanks for your contribution.
Unless you agree to remove this and use the same license (MIT), we sadly won't be able to merge it. |
|
Hi @emilevauge |
|
hi @emilevauge |
|
Hello @kyo-ke, Thanks for opening this PR! We have taken a first look at the changes and feel that addressing the configuration of the auth request method should be postponed until the need is raised by the community. |
17edec5 to
eac2182
Compare
Review issue-11029
|
Hello @kevinpollet @rtribotte |
kevinpollet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
rtribotte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What does this PR do?
The patch is to send request body to authorization server by forwardauth if forwardBody option is true.
Fixes #11029
Also related to community question : https://community.traefik.io/t/forward-auth-middleware-is-there-any-way-to-pass-whole-request-body/20011/2 .
Motivation
Sometimes authorization server want to use request body for authorization. Say some parameter in POST request is only open to specific user.
Always send body is not good for performance so create option for this functionality.
More
Additional Notes
Request body from client is in body of request to authorization sever.
Do not use header send request body to avoid encoding.
License Information
THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE MIT LICENSE. YOU MAY OBTAIN A COPY OF THE LICENSE AT
https://opensource.org/license/mit