Ensure shellcheck failure exit code is reflected in GH job result#11113
Merged
traefiker merged 2 commits intotraefik:v2.11from Oct 8, 2024
Merged
Ensure shellcheck failure exit code is reflected in GH job result#11113traefiker merged 2 commits intotraefik:v2.11from
traefiker merged 2 commits intotraefik:v2.11from
Conversation
youkoulayley
added
kind/enhancement
mmatur
approved these changes
Oct 8, 2024
traefiker
force-pushed
the
fix-shellcheck
branch
from
18c3d3a to
e46a548
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the previous implementation, the script would exit with code 0 as long as the last
shellcheckcommand succeeds. This PR ensures that if any of the individual checks fail, so does the script as a whole.Motivation
When trying to debug the failed job at https://github.com/traefik/traefik/actions/runs/10962448670/job/30441708688?pr=11111,
I compared to https://github.com/traefik/traefik/actions/runs/10955418669/job/30419255534 to check for differences. Although still not finding why the job on my PR is failing, I noticed shellcheck reporting errors in the latter job, which were not causing the job to fail.
More
Additional Notes