Add AbortOnPluginFailure option to abort startup on plugin load failure #11228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilevauge
added
status/2-needs-review
area/plugins
and removed
status/0-needs-triage
labels
rtribotte
requested changes
Nov 4, 2024
rtribotte
changed the title
RequirePluginsToStart
Contributor
|
🚫 checks status: PR status: cancelled |
Contributor
|
🚫 checks status: PR status: failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the
AbortOnPluginFailurefield in the staticConfiguration. When this field is set totrue, then Traefik won't start if one of the plugins (local & remote) has an error during initialization.Motivation
It's based on this issue: #10106 & my first PR which allows configuration by plugin: #10929
Fixes #10106
More
Additional Notes
If the field is not defined, Traefik will log the error and continue starting as usual.
If this PR is accepted, I'll create a new one in the helm repo to add the missing arg.