Add an option to preserve the ForwardAuth Server Location header

[Nelwhix]

What does this PR do?

Fixing issue #11313 where ForwardAuth middleware modifys the Location header instead of sending it as is.

Fixes #11313

More

• Added/updated tests
• Added/updated documentation

[kevinpollet]

Hello @Nelwhix and thanks for this contribution,

The way you address the issue is breaking because some users may rely on the current behavior of the ForwardAuth middleware. We may have not been clear enough, but the issue should be addressed in a non-breaking way. This means that an option should be added to the middleware to control whether the location header should be left as is (the new behavior) or resolved against the auth server address.

Also, as this is an enhancement, could you please rebase it on the master branch?

[Nelwhix]

Hi @kevinpollet, I understand what you mean. Now to find a new name for this field. What do you think of preserveLocationHeader ?

http:
  middlewares:
    test-auth:
      forwardAuth:
        preserveLocationHeader: true

[kevinpollet]

Hi @kevinpollet, I understand what you mean. Now to find a new name for this field. What do you think of preserveLocationHeader ?

@Nelwhix Thanks, it looks good to me.

[Nelwhix]

@kevinpollet made the changes

[rtribotte]

Hello @Nelwhix,

Thanks for your changes.
This new option needs to be documented, both in configuration references (you just need to run go generate to update them), and in the middleware specific page.
As well, the option needs to be replicated in our CRDs by adding it to traefikv1alpha1.ForwardAuth, and make use of it in createForwardAuthMiddleware func.

[Nelwhix]

Hi @rtribotte, I have made the updates.

[rtribotte]

Hello @Nelwhix,

Thanks for last changes!
Do you mind if I rebase you branch and push a review commit?

[Nelwhix]

No problem.

…

On Thu, Dec 12, 2024 at 4:41 PM Romain ***@***.***> wrote: Hello @Nelwhix <https://github.com/Nelwhix>, Thanks for last changes! Do you mind if I rebase you branch and push a review commit? — Reply to this email directly, view it on GitHub <#11318 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AN5IDMQXFW7F433GBQE66DD2FGVEJAVCNFSM6AAAAABS6W36D6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZZGMYTSMRYGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[rtribotte]

Thanks!

[kevinpollet]

Thanks 👍