Fix WASM settings #11321
Merged
Fix WASM settings #11321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliens
force-pushed
the
fix-wasm-settings
branch
from
cf0efc7 to
c0443d7
Compare
juliens
force-pushed
the
fix-wasm-settings
branch
from
c0443d7 to
1e0d5e0
Compare
kevinpollet
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug that prevented WASM plugins, loaded using wazero’s WASI preview 1 implementation, from properly utilizing environment variables or mounted files specified in the plugin settings.
Motivation
Fix the bug.
More
Additional Notes
For now, only test on WASM Plugins using wazero and compiled with tinygo are implemented. In the futur, we should implement more cases like plugins compiled with native go 1.24 ( with wasmexport ).