-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Disable MPTCP by default #11918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable MPTCP by default #11918
Conversation
nmengin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I'm not opposed to this PR, but I would note that the fundamental problem, a single connection failed syscall to set the keepalive will crash the entire internal endpoint completely transparently (except for a log message). The dashboard will still appear as though the endpoint is up, even though the endpoint server is down, but the larger point of the syscall for setting keepalive should perhaps not stop the endpoint. |
|
Hello @dtscd, Thank you for your feedback. We’ve also discussed making broader improvements to the socket creation options as a potential long-term solution, though it’s still in the planning phase. |
Co-authored-by: Kevin Pollet <pollet.kevin@gmail.com>
lbenguigui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@rtribotte thanks for this fix. This PR is merged into Isn't it wrong? I have this #11869 in traefik version |
Ah, I just realised, that |
What does this PR do?
This PR disables MPTCP by default, which has been activated by default by the recent bump to go1.24.
MPTCP is now only enabled with
GODEBUG=multipath=1.Motivation
It appears that enabling MPTCP on some platforms can cause Traefik to stop with the following error logs message:
Disabling it by default solves this issue.
Fixes #11869
More
Additional Notes
Co-authored-by: Kevin Pollet pollet.kevin@gmail.com