Skip to content

Make app protocol case insensitive#11989

Merged
traefiker merged 5 commits intotraefik:v3.5from
shreealt:make-app-protocol-case-insensitive
Aug 20, 2025
Merged

Make app protocol case insensitive#11989
traefiker merged 5 commits intotraefik:v3.5from
shreealt:make-app-protocol-case-insensitive

Conversation

@shreealt
Copy link
Contributor

@shreealt shreealt commented Aug 9, 2025

What does this PR do?

This pull request makes the app protocol case-insensitive.

Motivation

Fixes #11980

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @shreealt and thanks for opening this,

We reviewed your changes, and we think that they should be scoped to the one introduced by #11176.

Could you make the changes?

@shreealt
Copy link
Contributor Author

@kevinpollet I have made the requested changes, please review again.

also, please let me know if it would be correct to keep the scope of this PR to deal with case insensitivity for appProtocol only. My previous change tried to deal with case insensitivity for all usages of schemeHTTP and the likes of it.

@kevinpollet kevinpollet changed the title feat: make app protocol case insensitive Make app protocol case insensitive Aug 18, 2025
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shreealt,

Thanks for the adjustments. There are still modifications out of scope, can you please remove those?
Could you also add some tests? (or modify the existing ones)

@shreealt
Copy link
Contributor Author

@rtribotte done.

@shreealt shreealt requested a review from rtribotte August 20, 2025 05:26
@kevinpollet kevinpollet force-pushed the make-app-protocol-case-insensitive branch from 85d942c to 957e32b Compare August 20, 2025 07:20
@kevinpollet kevinpollet changed the base branch from master to v3.5 August 20, 2025 07:20
@kevinpollet kevinpollet added this to the 3.5 milestone Aug 20, 2025
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👏

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@traefiker
Copy link
Contributor

🚫 checks status: PR status: failure

@traefiker traefiker merged commit 3b33ffa into traefik:v3.5 Aug 20, 2025
62 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AppProtocol case is not ignored

4 participants