Skip to content

Log provider namespace during startup #12002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
traefiker merged 10 commits into from
Oct 3, 2025
Merged

Log provider namespace during startup #12002

traefiker merged 10 commits into from
Oct 3, 2025

Conversation

@shreealt
Copy link
Contributor

@shreealt shreealt commented Aug 17, 2025 •
edited by kevinpollet
Loading

Fixes #11982

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@rtribotte
Copy link
Member

rtribotte commented Aug 18, 2025

@shreealt Thanks for this contribution!

Would you mind if we added review commits? We have a few adjustments to make and want to extend the fix for the ConsulCatalog provider, and it is easier to push commits rather than interact here.

@shreemaan-abhishek
Copy link

shreemaan-abhishek commented Aug 19, 2025

sure!

@mmatur mmatur force-pushed the log-nomad-namespace branch from e81fc0c to 1f45d6a Compare September 26, 2025 12:41
@mmatur mmatur added this to the next milestone Sep 26, 2025
@mmatur mmatur force-pushed the log-nomad-namespace branch from 1f45d6a to db791ad Compare September 26, 2025 12:54
sdelicata
sdelicata requested changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@sdelicata sdelicata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shreealt and thanks for your contribution!
I made a few comments concerning tests and renamed the NamespaceProvider to NamespacedProvider that sounds more accurate.

sdelicata
sdelicata approved these changes Oct 3, 2025
View reviewed changes
Copy link
Contributor

@sdelicata sdelicata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinpollet kevinpollet changed the title feat(provider): log provider namespace during startup Log provider namespace during startup Oct 3, 2025
kevinpollet
kevinpollet approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@traefiker traefiker merged commit 7cc8b09 into traefik:master Oct 3, 2025
60 of 78 checks passed
@kevinpollet kevinpollet added kind/enhancement a new or improved feature. and removed kind/bug/fix a bug fix labels Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinpollet kevinpollet kevinpollet approved these changes

@sdelicata sdelicata sdelicata approved these changes

Assignees

No one assigned

Labels

area/provider/consul area/provider/consulcatalog area/provider/nomad kind/enhancement a new or improved feature. size/M

Projects

None yet

Milestone

3.6

Development

Successfully merging this pull request may close these issues.

Nomad provider appears twice during Traefik startup

8 participants

@shreealt @rtribotte @shreemaan-abhishek @kevinpollet @sdelicata @mmatur @nmengin @traefiker