fix: use UnixMilli in traefik_tls_certs_not_after_milliseconds metric
#12117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @shreealt, Thanks for this contribution! Please mark this PR as ready for review when you think it is ready — it will help us to know when we can start reviewing it. |
Signed-off-by: Shreemaan Abhishek <shreemaanabhishek@apache.org>
Contributor
Author
|
Thank you for your help @rtribotte, I have marked this PR ready for review. I have:
|
rtribotte
added
status/2-needs-review
kind/bug/fix
Member
|
Hi @shreealt, Thank you for addressing this. As this is a fix, could you please rebase the changes on the v3.5 branch? |
Contributor
Author
|
Hi @rtribotte, I raised: #12141 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12113
What does this PR do?
Motivation
More
Additional Notes