Fix ingress status if type ClusterIP#12134
Conversation
|
I have built the image and tested it in my Kubernetes cluster. It works like expected and without an issues. |
|
Hello @walnuss0815, Thank you for your contribution. Your PR looks more like a fix. Could you rebase it on the We've set the status to "design-review" to allow us to check the PR and ensure there is no deep impact on Traefik before moving forward. We'll keep you updated once the analysis is done. |
This commit fixes the Kubernetes ingress status if the traefik service is type `ClusterIP`. The field `.spec.clusterIPs` is now being used to generate the ingress status instead of the `ExternalIPs`. ExternalIPs is for IPs "for which nodes in the cluster will also accept traffic for this service". Ref: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.34/#servicespec-v1-core
fe1024e to
3d5b2bc
Compare
|
Hi @nmengin, I have rebased the fix on the |
|
I had the exact same problem, with my traefik Service running as type ClusterIP and ArgoCD being unable to see anything in the resulting Ingress objects' In case it's relevant, my instance of ArgoCD is running in the same Kubernetes cluster as Traefik and can, if it wants to, route traffic to the traefik Service's cluster IP address without leaving the cluster. I'm not sure this matters though: even if my ArgoCD instance were running externally to the Kubernetes cluster with no ability to route to the cluster IP address of the traefik Service, ArgoCD's health check for an Ingress only cares that the |
What does this PR do?
This PR fixes the Kubernetes ingress status if the traefik service is type
ClusterIP. The field.spec.clusterIPsis now being used to generate the ingress status instead of theExternalIPs. ExternalIPs is for IPs "for which nodes in the cluster will also accept traffic for this service".Ref: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.34/#servicespec-v1-core
Motivation
I am having the same issue as described here argoproj/argo-cd#14607 which should be fixed by #11100 , but due to the usage of the
externalIPsfield it does not work as intended if the service type isClusterIP.More
Additional Notes