Evaluate glide-hash result without reading $?.#1214
Merged
timoreimann merged 1 commit intotraefik:masterfrom Mar 2, 2017
Merged
Evaluate glide-hash result without reading $?.#1214timoreimann merged 1 commit intotraefik:masterfrom
timoreimann merged 1 commit intotraefik:masterfrom
Conversation
timoreimann
force-pushed
the
avoid-validate-glide-output-suppression
branch
2 times, most recently
from
90214b7 to
3108ac7
Compare
Contributor
Author
|
I added a bogus, manual change to the glide.yml file to demonstrate that the error message is now shown (see Travis CI output) and reverted it afterwards. Post-LGTM, I can either squash manually or we use Github's "squash and merge" feature to keep the Git history clean. @containous/traefik please take a look :) |
validate-glide is called with errexit enabled (in script/make.sh that sources validate-glide), which means that grep returning a non-zero exit code will cause the script to terminate prematurely. Thus, we will never get to the point where we see the error message. The fix is to embed the grep check directly inside the if statement.
timoreimann
force-pushed
the
avoid-validate-glide-output-suppression
branch
from
3108ac7 to
04a1ecc
Compare
Contributor
|
LGTM 👍 |
emilevauge
approved these changes
Mar 2, 2017
Member
emilevauge
left a comment
emilevauge
left a comment
There was a problem hiding this comment.
Oops 🤦♂️
LGTM
thanks @timoreimann
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate-glideis called witherrexitenabled (inscript/make.shthat sourcesvalidate-glide), which means that grep returning a non-zero exit code will cause the script to terminate prematurely. Thus, we will never get to the point where we see the error message.The fix is to embed the grep check directly inside the if statement.