Skip to content

Conversation

@justin0u0
Copy link

What does this PR do?

Introduce the --publishedserviceselector option to select and publish IPs from multiple services.

Motivation

Closes #11617.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@justin0u0
Copy link
Author

Hi @kevinpollet,

The test failed, but it is not related to my changes and seems like a flaky one.

Could you re-run the tests and take a look at this pull request?

Thanks!

@mmatur mmatur force-pushed the feat/published-service-selector branch from b7b673b to 9bb01ea Compare December 8, 2025 13:27
@kevinpollet
Copy link
Member

Hello @justin0u0, I restarted the tests.

@justin0u0 justin0u0 force-pushed the feat/published-service-selector branch 2 times, most recently from d41578d to 3f392d2 Compare December 11, 2025 14:39
@justin0u0
Copy link
Author

Hello @justin0u0, I restarted the tests.

Hi @kevinpollet, didn't notice that the new test added was flaky.

I've fixed it, please rerun the test and take a look, thanks!

@justin0u0 justin0u0 force-pushed the feat/published-service-selector branch from 3f392d2 to f88f80b Compare December 11, 2025 14:49
@justin0u0
Copy link
Author

@kevinpollet, sorry for the failed test again.

The TestIngressEndpointPublishedService test originally used assert.Equal to match ingress status. However, ASAIK, GetNodes() can return an arbitrary order of nodes, which sometimes caused the test to failed.

So I changed assert.Equal to assert.ElementsMatch under TestIngressEndpointPublishedService in 2615342.

I'm also wondering why the TestIngressEndpointPublishedService hadn't failed before?

@kevinpollet kevinpollet force-pushed the feat/published-service-selector branch from 2615342 to 153db46 Compare December 18, 2025 15:21
@kevinpollet
Copy link
Member

Hello @justin0u0,

I'm also wondering why the TestIngressEndpointPublishedService hadn't failed before?

You are right, I think this test fails occasionally.
If you want, you can fix it too in this pull request.

@justin0u0
Copy link
Author

Hello @justin0u0,

I'm also wondering why the TestIngressEndpointPublishedService hadn't failed before?

You are right, I think this test fails occasionally. If you want, you can fix it too in this pull request.

Hi @kevinpollet , I already did fixed TestIngressEndpointPublishedService with 153db46.

The latest test failure is not related to this pull request, please take a look 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Publish Multiple Services for Ingress

3 participants