-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Feat/published service selector #12281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feat/published service selector #12281
Conversation
|
Hi @kevinpollet, The test failed, but it is not related to my changes and seems like a flaky one. Could you re-run the tests and take a look at this pull request? Thanks! |
b7b673b to
9bb01ea
Compare
|
Hello @justin0u0, I restarted the tests. |
d41578d to
3f392d2
Compare
Hi @kevinpollet, didn't notice that the new test added was flaky. I've fixed it, please rerun the test and take a look, thanks! |
3f392d2 to
f88f80b
Compare
|
@kevinpollet, sorry for the failed test again. The So I changed I'm also wondering why the |
2615342 to
153db46
Compare
|
Hello @justin0u0,
You are right, I think this test fails occasionally. |
Hi @kevinpollet , I already did fixed The latest test failure is not related to this pull request, please take a look 🙏 |
What does this PR do?
Introduce the
--publishedserviceselectoroption to select and publish IPs from multiple services.Motivation
Closes #11617.
More
Additional Notes