Restore: First stage of access logging middleware. #1571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
force-pushed
the
restore-access-logger
branch
from
5eed593 to
75f1fe3
Compare
timoreimann
reviewed
May 10, 2017
| } | ||
|
|
||
| //------------------------------------------------------------------------------------------------- | ||
| // the next 3 function (SaveNegroniFrontend, NewSaveNegroniFrontend, ServeHTTP) are temporary, |
Contributor
There was a problem hiding this comment.
What's the reason we have the part from here to the rest of this file? It's not in the original PR.
Contributor
Author
There was a problem hiding this comment.
Because the code evolve between the first merge and the revert restoration.
Contributor
There was a problem hiding this comment.
Okay, I realized now that the functions were in the original PR but didn't include the Negroni part in the name.
Why the warning at the top and why change the names?
Member
There was a problem hiding this comment.
@timoreimann we worked both on resolving this conflict. we had to do this to manage different types negroni and http handlers.
This reverts commit 8265198.
ldez
force-pushed
the
restore-access-logger
branch
from
a1bae72 to
d2c8824
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restore access logging middleware.
Related to #1541, #1408, #1485