Adds definitions to backend kv template for health checking #1644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
kind/enhancement
emilevauge
reviewed
May 22, 2017
Member
emilevauge
left a comment
emilevauge
left a comment
There was a problem hiding this comment.
Great!
Minor improvement possible in the template ;)
Other than that, looks good!
templates/kv.tmpl
Outdated
Member
There was a problem hiding this comment.
We may move {{$interval := Get "30s" . "/healthcheck/" "interval"}} below {{with $healthCheck}} ?
Contributor
Author
There was a problem hiding this comment.
I followed the same format as the load balancer lines above (where {{$sticky := Get "false" . "/loadbalancer/" "sticky"}} is outside the with). I can move it inside the {{with $healthCheck}} if you want.
Member
There was a problem hiding this comment.
It's not mandatory, but it would be better :) And yes, we could do the same thing with sticky.
Contributor
Author
There was a problem hiding this comment.
@emilevauge I moved the interval Get into the with block.
ldez
added
area/provider/kv
status/2-needs-review
and removed
status/1-needs-design-review
labels
ldez
force-pushed
the
add-healthcheck-to-kv-tmpl
branch
from
dff989c to
5917e1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds definitions to the KV template to load backend health check information (path and interval).
I've only tested this change with the etcd backend.