Skip to content

Conversation

@sriyer
Copy link

@sriyer sriyer commented Jul 12, 2017

The changes to have this implemented for the Consul Catalog are here.

Fixes #1280

@sriyer sriyer changed the title #1280, added modifiecations for parsing out && and || on front end rule #1280, added modifications for parsing out && and || on front end rule Jul 12, 2017
@ldez ldez changed the title #1280, added modifications for parsing out && and || on front end rule added modifications for parsing out && and || on front end rule Jul 12, 2017
@ldez
Copy link
Contributor

ldez commented Jul 12, 2017

Thanks for the contribution 👍

Could you fix this problem:

These files are not properly gofmt'd:
 - provider/consul/consul_catalog.go

Please read CONTRIBUTING.md and run the command make to ensure your code build on your computer.

@sriyer
Copy link
Author

sriyer commented Jul 14, 2017

The problem is now fixed.

@emilevauge
Copy link
Member

@sriyer thanks for your contribution. We think it would be better to both support actual separators and new separators to stay backward compatible. Besides, it would be even better to not be Consul specific and add this new separators in rules.go parseRules. I'm sorry to inform you that therefore I prefer closing this one as we can not merge it. Feel free to contact us if you want some help on this :)

@emilevauge emilevauge closed this Jul 18, 2017
@sriyer
Copy link
Author

sriyer commented Jul 19, 2017

@emilevauge i'll take a look at rules.go . btw we have this in production already for consul catalog with discovery source being registrator.

@sriyer
Copy link
Author

sriyer commented Jul 19, 2017

"We think it would be better to both support actual separators and new separators to stay backward compatible" - the change on this pull request supports the use of both. It only replaces || with , and && with ;

@gtrias
Copy link

gtrias commented Sep 6, 2018

Is there any plan to merge this PR or any alternative workarround to achieve the same funcionality?
I need this feature as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use | , & instead of , and ; with frontend.rule

4 participants