Change Traefik intro video #1893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilevauge
force-pushed
the
change-intro-video
branch
from
b2d07a4 to
78fe2e0
Compare
Contributor
|
Any particular reason to remove the Devoxx video? why not keep it underneath? |
timoreimann
reviewed
Jul 25, 2017
README.md
Outdated
|
|
||
| Here is a talk given by [Ed Robinson](https://github.com/errm) at the [ContainerCamp UK](https://container.camp) conference. | ||
| You will learn fundamental Træfik features and see some demos with Kubernetes. | ||
| Here is a talk given by [Emile Vauge](https://github.com/emilevauge) at [GopherCon](https://gophercon.com/) conference. |
Contributor
There was a problem hiding this comment.
"at GopherCon conference" -> "at the GopherCon conference"
Member
Author
Yes: this Devoxx video was old (April 2016), in French, and long. I think it's better to have a 5 minutes intro in (bad) English at first :) |
emilevauge
force-pushed
the
change-intro-video
branch
from
78fe2e0 to
d904f4c
Compare
Signed-off-by: Emile Vauge <emile@vauge.com>
emilevauge
force-pushed
the
change-intro-video
branch
from
d904f4c to
fd1fc22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the video in the readme to the new video made at GopherCon 2017. As it is less than 10m long, it makes a good quick introduction.