Skip to content

Websocket parameters and protocol. #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
traefiker merged 1 commit into from
Aug 20, 2017
Merged

Websocket parameters and protocol. #1970

traefiker merged 1 commit into from
Aug 20, 2017

Conversation

@ldez
Copy link
Contributor

@ldez ldez commented Aug 18, 2017 •
edited
Loading

Description

Fixes #1930
Partially #1945

@ldez ldez added this to the 1.3 milestone Aug 18, 2017
emilevauge
emilevauge approved these changes Aug 18, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Aug 18, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez changed the title Webscocket parameters and protocol. Websocket parameters and protocol. Aug 18, 2017
@ldez ldez added the area/oxy label Aug 18, 2017
@ldez ldez mentioned this pull request Aug 20, 2017
Closed
@traefiker traefiker merged commit 40e18db into traefik:v1.3 Aug 20, 2017
@ldez ldez deleted the fix/ws-forward branch August 22, 2017 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilevauge emilevauge emilevauge approved these changes

@nmengin nmengin nmengin approved these changes

+1 more reviewer

@timoreimann timoreimann timoreimann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/oxy area/websocket kind/bug/fix a bug fix size/S

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

5 participants

@ldez @timoreimann @emilevauge @nmengin @traefiker