Skip to content

Conversation

@dahefanteng
Copy link
Contributor

What does this PR do?

Just fix typo issue,try to avoid mislead others.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you could also replace v3 requires ETCD_IP_ADDRESS by V3 requires ETCD_IP_ADDRESS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right,I have replaced that.

@ldez ldez added kind/enhancement a new or improved feature. and removed contributor/waiting-for-corrections labels Nov 22, 2017
@ldez ldez changed the title Fix typo Fix typo in examples Nov 22, 2017
@ldez ldez added this to the 1.5 milestone Nov 22, 2017
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants