Fix kubernetes path prefix rule with rewrite-target #2461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheungpat
force-pushed
the
fix-rewrite-target-rule
branch
from
f2e27b4 to
fbca00e
Compare
Contributor
|
I think this makes sense. @dtomcej @emilevauge WDYT? |
dtomcej
approved these changes
Nov 25, 2017
Contributor
dtomcej
left a comment
dtomcej
left a comment
There was a problem hiding this comment.
Good catch @cheungpat!
LGTM
Contributor
|
I approved because I can't think that the code would be intended to function the way it was written :P I assume that @cheungpat's PR was what was intended. |
ldez
added
status/2-needs-review
kind/enhancement
ldez
added
kind/bug/fix
timoreimann
approved these changes
Nov 25, 2017
Contributor
|
@ldez do we plan to make another 1.4 patch release, or is it okay to let the fix go into the upcoming 1.5 / master? |
When rewrite-target is specified, any existing PathPrefix rule is removed. Hence an ingress with rewrite-target is always matched for the same host regardless of path prefix.
ldez
force-pushed
the
fix-rewrite-target-rule
branch
from
fbca00e to
6fa6491
Compare
Contributor
Author
|
Thanks for merging the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rewrite-target is specified, any existing PathPrefix rule is
removed. Hence an ingress with rewrite-target is always matched
for the same host regardless of path prefix.