Skip to content

Builders in k8s tests #2513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
traefiker merged 1 commit into from
Dec 5, 2017
Merged

Builders in k8s tests #2513

traefiker merged 1 commit into from
Dec 5, 2017

Conversation

@ldez
Copy link
Contributor

@ldez ldez commented Dec 3, 2017

What does this PR do?

Use builders in k8s tests.

Motivation

Simplify the maintenance.

More

  • Added/updated tests

@ldez ldez added this to the 1.6 milestone Dec 3, 2017
@ldez ldez requested a review from a team as a code owner December 3, 2017 19:38
@ldez ldez added the kind/enhancement a new or improved feature. label Dec 3, 2017
mmatur
mmatur requested changes Dec 4, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @ldez 👏

provider/kubernetes/builder_configuration_test.go Outdated
Copy link
Member

@mmatur mmatur Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename v into value or w please

provider/kubernetes/builder_configuration_test.go Outdated
Copy link
Member

@mmatur mmatur Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rename v into value

provider/kubernetes/builder_configuration_test.go Outdated
Copy link
Member

@mmatur mmatur Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rename func entryPoint into entryPoints

provider/kubernetes/builder_configuration_test.go Outdated
Copy link
Member

@mmatur mmatur Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rename Redirect into redirect

provider/kubernetes/builder_endpoint_test.go Outdated
Copy link
Member

@mmatur mmatur Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rename v into value

provider/kubernetes/builder_service_test.go Outdated
Copy link
Member

@mmatur mmatur Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rename v into value or name

provider/kubernetes/builder_service_test.go Outdated
Copy link
Member

@mmatur mmatur Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rename v into value or uid

provider/kubernetes/builder_service_test.go Outdated
Copy link
Member

@mmatur mmatur Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rename v into value or ip

provider/kubernetes/builder_service_test.go Outdated
Copy link
Member

@mmatur mmatur Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rename v into value

provider/kubernetes/builder_service_test.go Outdated
Copy link
Member

@mmatur mmatur Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rename v into value or name

@ldez ldez force-pushed the refactor/k8s-tests branch 2 times, most recently from bd97a6b to b61607f Compare December 4, 2017 18:28
@ldez ldez changed the base branch from v1.5 to master December 4, 2017 18:28
mmatur
mmatur requested changes Dec 5, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last renaming :)

provider/kubernetes/builder_service_test.go Outdated
Copy link
Member

@mmatur mmatur Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please replace v into value

nmengin
nmengin approved these changes Dec 5, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 👏

@ldez ldez force-pushed the refactor/k8s-tests branch 2 times, most recently from d6627bd to 9b387a8 Compare December 5, 2017 18:59
@ldez ldez force-pushed the refactor/k8s-tests branch from 9b387a8 to 119b71b Compare December 5, 2017 19:07
mmatur
mmatur approved these changes Dec 5, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

dtomcej
dtomcej approved these changes Dec 5, 2017
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit e2190bd into traefik:master Dec 5, 2017
@ldez ldez deleted the refactor/k8s-tests branch December 15, 2017 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

+1 more reviewer

@dtomcej dtomcej dtomcej approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/provider/k8s/ingress kind/enhancement a new or improved feature. size/L

Projects

None yet

Milestone

1.6

Development

Successfully merging this pull request may close these issues.

5 participants

@ldez @mmatur @nmengin @dtomcej @traefiker