Skip to content

Use prefix for sticky and stickiness tags. #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
traefiker merged 1 commit into from
Jan 2, 2018
Merged

Use prefix for sticky and stickiness tags. #2624

traefiker merged 1 commit into from
Jan 2, 2018

Conversation

@ldez
Copy link
Contributor

@ldez ldez commented Dec 27, 2017 •
edited
Loading

What does this PR do?

Use prefix for sticky and stickiness tags.

Motivation

Fixes #2623

More

  • Added/updated tests

@traefiker traefiker added this to the 1.5 milestone Dec 27, 2017
@ldez ldez mentioned this pull request Dec 27, 2017
Closed
juliens
juliens approved these changes Dec 27, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Dec 27, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Dec 27, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charlieoleary
Copy link
Contributor

charlieoleary commented Jan 1, 2018

Finally got the chance to test this out and confirmed that it works as expected. 👍

nmengin
nmengin approved these changes Jan 2, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 75533b2 into traefik:v1.5 Jan 2, 2018
@ldez ldez deleted the fix/consul-catalog-sticky-prefix branch January 2, 2018 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

Assignees

No one assigned

Labels

area/provider/consulcatalog kind/bug/fix a bug fix size/S

Projects

None yet

Milestone

1.5

Development

Successfully merging this pull request may close these issues.

6 participants

@ldez @charlieoleary @juliens @mmatur @nmengin @traefiker