Skip to content

Conversation

@timoreimann
Copy link
Contributor

What does this PR do?

Improve documentation on Marathon service labels.

Motivation

End-user support questions demonstrated that the distinction between application and service labels wasn't clear. Specifically, it wasn't obvious that services can be used to leverage Marathon applications exposing multiple ports.

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the marathon-docs-label-improvements branch from f1ed237 to c03d1f7 Compare January 2, 2018 09:54
@traefiker traefiker merged commit 4819974 into traefik:v1.5 Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants