Skip to content

Remove web provider in example #2807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
traefiker merged 2 commits into from
Feb 5, 2018
Merged

Remove web provider in example #2807

traefiker merged 2 commits into from
Feb 5, 2018

Conversation

@pigletfly
Copy link
Contributor

@pigletfly pigletfly commented Feb 5, 2018

update demo command parameter

@pigletfly pigletfly requested a review from a team as a code owner February 5, 2018 10:10
@pigletfly pigletfly requested a review from a team as a code owner February 5, 2018 13:16
@ldez ldez changed the title Fix:web provider configuration is deprecated, use api instead Remove web provider in documentation Feb 5, 2018
ldez
ldez approved these changes Feb 5, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Feb 5, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez changed the title Remove web provider in documentation Remove web provider in example Feb 5, 2018
juliens
juliens approved these changes Feb 5, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur added this to the 1.6 milestone Feb 5, 2018
@traefiker traefiker merged commit c0563f1 into traefik:master Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@traefiker traefiker traefiker approved these changes

+1 more reviewer

@ldez ldez ldez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/documentation area/provider/k8s/ingress size/S

Projects

None yet

Milestone

1.6

Development

Successfully merging this pull request may close these issues.

5 participants

@pigletfly @juliens @mmatur @ldez @traefiker