Server weight zero #3130
Merged
Server weight zero #3130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
force-pushed
the
refactor/weight-zero
branch
from
f9ef3aa to
3995df4
Compare
timoreimann
approved these changes
Apr 4, 2018
Contributor
timoreimann
left a comment
timoreimann
left a comment
There was a problem hiding this comment.
Nice, been looking forward to this one. 👍
ldez
force-pushed
the
refactor/weight-zero
branch
from
3995df4 to
e183260
Compare
Contributor
|
Looking forward to this one too! |
ldez
force-pushed
the
refactor/weight-zero
branch
2 times, most recently
from
72e466f to
7dbe33e
Compare
SantoDE
approved these changes
Apr 11, 2018
Collaborator
SantoDE
left a comment
SantoDE
left a comment
There was a problem hiding this comment.
LGTM 👼 This will be useful once its merged! :)
traefiker
force-pushed
the
refactor/weight-zero
branch
from
21ae912 to
1183653
Compare
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, a server with a weight of
0continue to receive calls: it's because if a server have a weight of0the real weight is1.These PR change this behavior:
0will have a real weight of0.0, the server will be removed from the available servers.Motivation
Fixes #1294
More
Additional Notes
Related to vulcand/oxy#121, containous/oxy#18, #1780